bunch of fixes/changes to make packages build #1006
Conversation
|
Use it externally in v2: // a.php
if (preg_match('/after-library\[(.*)\]-build/', patch_point(), $match)) {
$lib_name = $match[1];
FileSystem::removeDir(SOURCE_PATH . '/' . $lib_name);
}
|
|
That's not working FYI. |
|
I'm silly. Forgot <?php... |
henderkes
force-pushed
the
henderkes-patch-1
branch
from
0eda08d to
9e051c8
Compare
|
And I need another vacation. The composer update before push failed because it failed to remove go package stuff in pkgroot. The bugs actually seem fixed. |
|
Everything builds now, except for the macos intel failure, I guess. |
|
Looks like it's a JIT bug on x86_64 mAC05. |
|
Upstream issue here: php/php-src#20767 . Looks like we will need to exclude clang version manually here or use homebrew llvm instead. |
|
Swoole is broken on 8.5 until 6.2 release. Nothing we can realistically do there except manually using custom source option for download. Keeping this PR frozen but open until Swoole releases 6.2. We don't need to add a patch for a dev version, I just need it to build swoole extension for packages.
That will be fixed soon, we don't need to patch for it. |
henderkes
force-pushed
the
henderkes-patch-1
branch
from
ce7829f to
64f7a35
Compare
|
@crazywhalecc If you have a free minute (or a few) it might be worth still getting this into v2 since it contains actual fixes. I'm happy to rebase v3 against it afterwards. |
|
I recently had to pause development on v3 because my full-time job was a bit busy, and I was also moving to a new house. But I will check this again tomorrow / it seemed good last time. |
| "libargon2.a" | ||
| ], | ||
| "lib-suggests": [ | ||
| "libsodium" |
There was a problem hiding this comment.
Why it depends on libsodium?
There was a problem hiding this comment.
It doesn't depend on libsodium, but because they implement a lot of the same symbols, this orders them correctly. I got rid of the patch in password_argon2.php instead as it failed with -lsodium -largon2.
Because this now suggests libsodium, meaning libsodium may contain symbols this library "relies on", SPC makes sure that libsodium comes after libargon2 everywhere. Because libargon2 implements all symbols of libsodium, no further symbols will be needed during linking and libsodium is ignored.
| "type": "ghtagtar", | ||
| "repo": "pnggroup/libpng", | ||
| "match": "v1\\.6\\.\\d+", | ||
| "query": "?per_page=150", |
There was a problem hiding this comment.
Is this necessary, or is it only libpng that needs this?
There was a problem hiding this comment.
Only libpng needs this. They released a lot of v1.7 betas, so the latest 1.6 version is only on page 3.
What does this PR do?